Replace gulp-sass-lint with gulp-postcss / stylelint #105

agibson-godaddy · 2026-01-21T20:03:18Z

Issue: https://godaddy-corp.atlassian.net/browse/MWC-17960

Summary

This replaces the unmaintained gulp-sass-lint with gulp-postcss / stylelint. It also adds a lint config, which disables a ton of rules just to avoid suddenly switching to this method and ending up with a ton of warnings you didn't have before. IMO it's up to individual plugins to override these lint rules (supported).

To override:

Create a new .stylelintrc.json file in plugin directory with desired rules.

Update sake config:

  // sake.config.js
  module.exports = {
    tasks: {
        lint: {
            stylelintConfigFile: '.stylelintrc.json' // relative to current directory
        }
    }
    // ... other sake configuration
  }

This change also supports fixing lint errors with a --fix flag.

QA

Use a plugin that has SCSS - https://github.com/gdcorp-partners/woocommerce-customer-order-csv-export/pull/107
Use this development version of Sake
In the plugin's directory, run sake lint:scss
- No fatal errors (lint errors are okay)
Run sake compile:scss
- No errors
- CSS renders okay
Run sake lint:scss --fix -- QA for this step onwards only works if you had at least 1 lint error, which csv export does
- No errors
Run git status
- You see modified scss files
Run git diff
- Changes make sense

Here's an output of the changes from woocommerce-customer-order-csv-export :

 sake lint:scss
[12:29:24] Using gulpfile ~/Projects/sake/gulpfile.js
[12:29:24] Starting 'lint:scss'...
[12:29:24] Fixing lint errors...
[12:29:25] gulp-postcss: admin/wc-customer-order-csv-export-admin.scss
stylelint: /home/agibson/www/plugins/wp-content/plugins/woocommerce-customer-order-csv-export/assets/css/admin/wc-customer-order-csv-export-admin.scss:24:2: Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)
stylelint: /home/agibson/www/plugins/wp-content/plugins/woocommerce-customer-order-csv-export/assets/css/admin/wc-customer-order-csv-export-admin.scss:24:2: Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)
stylelint: /home/agibson/www/plugins/wp-content/plugins/woocommerce-customer-order-csv-export/assets/css/admin/wc-customer-order-csv-export-admin.scss:102:3: Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)
stylelint: /home/agibson/www/plugins/wp-content/plugins/woocommerce-customer-order-csv-export/assets/css/admin/wc-customer-order-csv-export-admin.scss:127:4: Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)
[[[truncated]]]
[12:29:25] Finished 'lint:scss' after 609 ms

$ git status
On branch address-sass-compiling-errors
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   assets/css/admin/wc-customer-order-csv-export-admin.scss

and $git diff (truncated)

diff --git a/assets/css/admin/wc-customer-order-csv-export-admin.scss b/assets/css/admin/wc-customer-order-csv-export-admin.scss
index a78f648..f8a093e 100644
--- a/assets/css/admin/wc-customer-order-csv-export-admin.scss
+++ b/assets/css/admin/wc-customer-order-csv-export-admin.scss
@@ -21,8 +21,8 @@ $blue:          #2ea2cc;
                width:2em;
        }

-       .download_to_csv:after,
-       .download_to_xml:after {
+       .download_to_csv::after,
+       .download_to_xml::after {
                @include mixins.dashicon( "\f316" );
        }
 }
@@ -99,7 +99,7 @@ $blue:          #2ea2cc;
        .transfer_status_head {
                @include mixins.dashicon-ir;
                line-height: 1;
-               &:after {
+               &::after {
                        @include mixins.dashicon( "\f317" );
                }
        }
@@ -124,7 +124,7 @@ $blue:          #2ea2cc;
                        font-size: 1.4em;
                        margin: 0 auto;

-                       &:after {
+                       &::after {
                                font-family: WooCommerce;
                                speak: none;
                                font-weight: 400;
@@ -143,28 +143,28 @@ $blue:          #2ea2cc;
                        }
                }

-               mark.queued:after {
+               mark.queued::after {
                        content: "\e012";
                        color: $orange;
                }

-               mark.completed:after {
+               mark.completed::after {
                        content: "\e015";
                        color: $blue;
                }

-               mark.failed:after {
+               mark.failed::after {
                        content: "\e013";
                        color: $red;
                }

After merge

Update config docs with new sasslint option

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR replaces the unmaintained gulp-sass-lint package with a modern stylelint-based linting solution using gulp-postcss and stylelint. The change includes a default configuration that disables many rules to maintain compatibility with existing projects while allowing individual plugins to override settings via their own .stylelintrc.json files.

Changes:

Removed dependency on deprecated gulp-sass-lint and added stylelint, postcss-scss, and related packages
Updated the SCSS linting task to use postcss pipeline with stylelint
Added a default stylelint configuration with many rules disabled for backward compatibility

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tasks/lint.js	Updated lintScssTask to use postcss/stylelint instead of gulp-sass-lint, with support for custom config files
package.json	Removed gulp-sass-lint dependency and added stylelint, postcss-scss, and stylelint-config-standard-scss
lib/lintfiles/.stylelintrc.json	Added default stylelint configuration extending standard SCSS config with many rules disabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tasks/lint.js

nikolas4175-godaddy

A couple comments on things we could clean up, but no major concerns. Completed QA on Memberships without issue, and I also confirmed I was able to override rules with the addition of .stylelintrc.json file 👍 Love having a --fix command! 🚀

tasks/lint.js

package.json

nikolas4175-godaddy

All questions addressed 👍

agibson-godaddy added 30 commits February 28, 2025 13:11

Replace instances of require() with import

1054f7f

Move config to separate file that we can export

f1be39f

Initialize config from inside sake file

67e1f65

Refactor replacement pipes

ea38b7a

Export scripts

b9ad28d

Refactor validation task

d05267b

Refactor bump task

95ae9ed

Rework wc tasks

d6cb231

Only import the fs function we use

a6a6826

Rework config task

742c38a

Rework linting

b20d287

Rework imagemin

c87cc19

Adjust gulpif import

a8d9bd3

Rework shell tasks

8f118fe

Rework watch

47a4296

Rework styles

6e429df

Rework makepot

975f55e

Rework decaffeinate

0a99b85

Rework clean tasks

08d14e1

Rework compile task

2182c87

Rework scripts

f1ff8e8

Rework github tasks

0f20169

Rework zip

d235325

Rework prompt

75f1ebb

Rework bundle

40a5a55

Use task suffix in constants

06141a6

Use task suffix

beafea5

Use task suffix

5c517b0

Use task suffix

e1c28d6

Use task suffix

a68bfe0

agibson-godaddy and others added 7 commits August 22, 2025 12:39

Execute codename as a function

b7ba4da

Fix typo

2bb4f13

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

FIx merge conflict

d10d31c

Update gulp-cli

17ce641

Replace gulp-sass-lint with gulp-postcss / stylelint

dd230b4

Includes postcss-scss

da4234f

Relax linting rules

78ad7a3

Base automatically changed from mwc-17961 to master January 30, 2026 12:40

An error occurred while trying to automatically change base from mwc-17961 to master January 30, 2026 12:40

agibson-godaddy added 3 commits January 30, 2026 12:59

Fix merge conflicts

b27fc58

Merge branch 'master' into mwc-17960

fb85a0f

Remove rule

8184fcb

agibson-godaddy marked this pull request as ready for review January 30, 2026 14:19

agibson-godaddy requested a review from Copilot January 30, 2026 14:19

Copilot AI reviewed Jan 30, 2026

View reviewed changes

tasks/lint.js Outdated Show resolved Hide resolved

Move lint config file to config

8f9793a

agibson-godaddy self-assigned this Feb 2, 2026

agibson-godaddy added 2 commits February 2, 2026 12:07

Merge branch 'master' into mwc-17960

534ce32

Add support for fixing lint errors

c01ed68

agibson-godaddy requested review from ajaynes-godaddy, nikolas4175-godaddy and nmolham-godaddy February 2, 2026 12:30

nikolas4175-godaddy previously approved these changes Feb 3, 2026

View reviewed changes

tasks/lint.js Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

Only log if we're actually fixing!

66f2094

agibson-godaddy dismissed nikolas4175-godaddy’s stale review via 66f2094 February 3, 2026 11:49

Update stylelint to v17.1.0

d814440

nikolas4175-godaddy self-requested a review February 3, 2026 17:47

nikolas4175-godaddy approved these changes Feb 3, 2026

View reviewed changes

agibson-godaddy merged commit f5abc74 into master Feb 4, 2026

agibson-godaddy deleted the mwc-17960 branch February 4, 2026 11:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace gulp-sass-lint with gulp-postcss / stylelint #105

Replace gulp-sass-lint with gulp-postcss / stylelint #105

Uh oh!

agibson-godaddy commented Jan 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

nikolas4175-godaddy left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

nikolas4175-godaddy left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Replace gulp-sass-lint with gulp-postcss / stylelint #105

Replace gulp-sass-lint with gulp-postcss / stylelint #105

Uh oh!

Conversation

agibson-godaddy commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

QA

After merge

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

nikolas4175-godaddy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nikolas4175-godaddy left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

agibson-godaddy commented Jan 21, 2026 •

edited

Loading

nikolas4175-godaddy left a comment •

edited

Loading